sub get_index (\@$) { 
  my ($a, $e) = @_; 
  my $i = 0; 
  for (@$a) { return $i if $e eq $_; $i++; } 
  return -1; 
}

[download]
I don't like code like this because you've got two things in that loop that are being kept in sync only coincidentally: the iteration of the foreach, and the incrementing of the index. I'd let there be one thing, and use the indirection to ensure consistency: 
sub get_index (\@$) {
  my ($a, $e) = @_;
  for (my $i = 0; $i <= $#$a; $i++) {
    return $i if $e eq $a->[$i];
  }
  return -1;
}

[download]
This is clearer to me. Simple things should be coded simply. {grin}

-- Randal L. Schwartz, Perl hacker

In reply to Re: Simple things should be coded simply (Re: Idiomatic Array Index Search?) by merlyn
in thread Idiomatic Array Index Search? by footpad

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.