Ok.
I think what you have is a bit complex. Consider the below... The two regex terms in the "grep{}" can be combined. I show a simple formulation without doing that. If you have just a few hundred files, tweaking this further won't make any performance difference at all. Clarity is often a lot more important than getting the nth degree of performance.
#!/usr/bin/perl
use strict;
use warnings;
print "Please enter text for string search: ";
my $search=<STDIN>;
chomp $search;
print "Please specific a directory: ";
my $directory=<STDIN>;
chomp $directory;
opendir(DIR, $directory) or
die "Cannot open directory: $directory \n";
my @files = grep{ m/$search\.jpg$/i
or
m/$search\.jpeg$/i
}readdir (DIR);
print "No files found in $directory\n" unless @files;
foreach my $file (@files)
{
print "$directory/$file\n";
}
Oops: if $search is a regex, you will need \Q$search\E
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.