That is impressively complex for a "first perl program"!.
Others have directed you toward debugging (push a hashref into the array, instead of hash).
This note focuses more on perl STYLE - in particular, your use of c-style loops, which, although usable, are better written "perl style". Your loop:
for $i ( 1 .. $#allmolecules ) {
...
could be re-coded (untested) as:
for my $currentMolecule ( @allmolecules ) {
...
while (my ($key,$val) = each %$currentMolecule ) { #line 222
if (ref($val) eq "ARRAY")
{ print "$key=@$val"; }
else
{ print "$key=$val"; }
...
}
}
Note the use of "my" to localize the scope of temporary variables.
update: Changed inner "for" loop into a "while (my ($k,$v)=each.." loop after I noticed the O.P. needed both the key AND the value.
Syntactic sugar causes cancer of the semicolon. --Alan Perlis
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.