I have written the following code for recreating a given directory structure. (it works fine)

How more efficient can you make it 

#!/usr/local/bin/perl
use warnings;
use strict;

my $recreate_to = 'C:/Documents and Settings/My Documents/TEST';
my $topdir = 'H:/';
&dirs($topdir);

sub dirs{
    my $dir = shift;

    opendir (DIR,$dir)
    || die "unable top open dir $dir $!";
    my @files = grep(/\w+/,readdir(DIR));
    close (DIR);

    foreach  my $subdir (@files){
        if(-d $dir.'/'.$subdir){
            my $level = $dir . '/' .$subdir;
            my $newfolder = $level;
            $newfolder =~ s/$topdir/$recreate_to/;
            print "New folder: $newfolder\n";
             #            mkdir ($newfolder);
            &dirs($level);
        }
    }
}

[download]

skywalker

In reply to Recursive sub efficiency by skywalker

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.