If each plugin had a single handler then all the work of remembering which parts of the plugin had been completed and which had not would have to be implemented inside every individual plugin's single error handler,

Where'd you get that from? I didn't suggest removing any calls to register. I suggested you pass an object as argument.

do_a(); my::Error::register(\&undo_a, ARGS); if ($do_c) { do_c(); my::Error::register(\&undo_c, ARGS); } do_b(); my::Error::register(\&undo_b, ARGS);
to
do_a(); register_err_handler(a => ARGS); if ($do_c) { do_c(); register_err_handler(c => ARGS); } do_b(); register_err_handler(b => ARGS); sub register_err_handler { my::Error::register( my::Plugin::ErrorHandler_->new(@_) ); }

The handler is trivial:

package my::Plugin::ErrorHandler; sub new { my $class = shift; my $handler = shift; return bless({ handler => $handler, args => [ @_ ] }, $class); } my %dispatch = ( a => \&my::Plugin::undo_a, b => \&my::Plugin::undo_b, c => \&my::Plugin::undo_c, ); sub handle_error { my ($self) = @_; $dispatch{ $self->{handler} }->(@{ $self->{args} }) }

This gives you a lot of flexibility (including the ability to serialise undo data) without messing with magic.

That said, given the details that recently came to light, yes, you might as well do

do_a(); my::Error::register(undo_a => ARGS); if ($do_c) { do_c(); my::Error::register(undo_c => ARGS); } do_b(); my::Error::register(undo_b => ARGS);

You can always pass an object as one of the args if if custom serialisation is needed.


In reply to Re^7: Saving/recovering sub refs in a file by ikegami
in thread Saving/recovering sub refs in a file by madscientist

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.