Untested, but I think this should run substantially more quickly.

The basic idea is instead of converting all 11 million GMT dates to match your PST target date, you convert the target date to GMT and use a simple regex to do the matching:

my $target = UnixDate( Date_ConvTZ( ParseDate("3 days ago"), 'PST', 'GMT' ) ,"%e/%h/%Y" ); open DATA,">$ARGV[1]"; open FH,"$ARGV[0]"; m/\[$target:/ and print DATA $_ while <FH>; close DATA; close FH;

If there might be other dates embedded in the log that would be matched by the regex [...:, then you might need to elaborate the regex to isolate the required date.

Alternatively, if as your sample suggests the required date is at a set offset from the start of the line, you might use:

substr( $_, 34, 11 ) eq $target and print DATA $_ while <FH>

which as a straight string compare would be even quicker.

This assumes that your "3 days earlier" runs midnight to midnight GMT on that day. If you need to cater for the timezone shift of the start and end of day, then things get more complicated. But your code doesn't appear to be doing that.

In that case I probably calculate the unixtime (seconds since epoch) of the start and end times, convert the log date/times to the same and use a numeric compare:

print if $logSecs > $startSecs && $logSecs < $endSecs;

Examine what is said, not who speaks -- Silence betokens consent -- Love the truth but pardon error.
"Science is about questioning the status quo. Questioning authority".
In the absence of evidence, opinion is indistinguishable from prejudice.
RIP an inspiration; A true Folk's Guy

In reply to Re: optimize the code by BrowserUk
in thread optimize the code by Anonymous Monk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.