This is the input file, and it has combination of GMT dates.
74.13.151.1 - - [22/Jun/2010:06:00:00 +0000] GET 67.195.112.248 - - [21/Jun/2010:20:09:42 +0000] GET 99.138.106.5 - - [21/Jun/2010:23:10:18 +0000] GET 99.138.106.5 - - [21/Jun/2010:09:10:18 +0000] GET
When I run the script using the code below.
#!/usr/bin/perl use strict; use warnings; use Date::Manip; my $date_converted = UnixDate(ParseDate("3 days ago"),"%e/%h/%Y"); open DATA,">$ARGV[1]"; open FH,"$ARGV[0]"; while(<FH>){ my @tab_delimited_array = split(/\t/,$_); $tab_delimited_array[3] =~ s/^\[//; $tab_delimited_array[3] =~ s/^\-//; chomp($tab_delimited_array[3]); if(length($tab_delimited_array[3]) > 1) { my $date_format = UnixDate($tab_delimited_array[3],"%Y%m%d%H:%M:%S +"); my $converted_date = Date_ConvTZ("$date_format",'GMT','PST'); my $pst_converted_date = UnixDate($converted_date,"%e/%h/%Y:%H:%M: +%S"); $pst_converted_date =~ s/^\s//g; my $extracted_YMD=UnixDate($converted_date,"%e/%h/%Y"); $_ =~ s/$tab_delimited_array[3]/$pst_converted_date/g; if($extracted_YMD =~ m/$date_converted/){ print DATA $_; } } } close DATA; close FH;
output is
74.13.151.1 - - [21/Jun/2010:22:00:00 +0000] GET 67.195.112.248 - - [21/Jun/2010:12:09:42 +0000] GET 99.138.106.5 - - [21/Jun/2010:15:10:18 +0000] GET
When I use the code,it is matching the input file for just 3 days ago.
my $target = UnixDate(Date_ConvTZ( ParseDate("3 days ago"), 'GMT', 'PS +T' ),"%e/%h/%Y"); print $target; open DATA,">$ARGV[1]"; open FH,"$ARGV[0]"; m/\[$target:/ and print DATA $_ while <FH>; close DATA; close FH;
Output is:
67.195.112.248 - - [21/Jun/2010:20:09:42 +0000] GET 99.138.106.5 - - [21/Jun/2010:23:10:18 +0000] GET
please tell me how to optimize the code to read the date/time from input file and convert to PST time.
while(<FH>){ my @tab_delimited_array = split(/\t/,$_); $tab_delimited_array[3] =~ s/^\[//; $tab_delimited_array[3] =~ s/^\-//; chomp($tab_delimited_array[3]); if(length($tab_delimited_array[3]) > 1) { my $date_format = UnixDate($tab_delimited_array[3],"%Y%m%d%H:%M:%S +"); my $converted_date = Date_ConvTZ("$date_format",'GMT','PST'); my $pst_converted_date = UnixDate($converted_date,"%e/%h/%Y:%H:%M: +%S"); $pst_converted_date =~ s/^\s//g; my $extracted_YMD=UnixDate($converted_date,"%e/%h/%Y"); $_ =~ s/$tab_delimited_array[3]/$pst_converted_date/g; if($extracted_YMD =~ m/$date_converted/){ print DATA $_; } } }

In reply to Re^2: optimize the code by Anonymous Monk
in thread optimize the code by Anonymous Monk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.