BrowserUk,
Yes, there were at least 2 bugs. Try this instead. 
#!perl -slw
use strict;
use List::Util qw/ shuffle /;

sub x {
    my( $N, @M ) = @_;
    my ($minus_1, $minus_2) = ($M[rand @M], $M[rand @M]);
    my $str = $minus_1 . $minus_2;

    for (1 .. $N - 2) {
        my $idx = rand @M;
        $idx = ($idx + (int(rand $#M) + 1)) % @M if $minus_1 eq $minus
+_2 && $M[$idx] eq $minus_2;
        $str .= $M[$idx];
        ($minus_1, $minus_2) = ($minus_2, $M[$idx]);
    }
    return $str;
}

for( 1 .. 100 ) {
    my $x = x( 12, qw[ A B C D E F ] );
    print $x, $x =~ m[(.)\1\1] ? ' Fail' : ' Ok';
}

[download]

Cheers - L~R

In reply to Re^3: Random data generation. by Limbic~Region
in thread Random data generation. by BrowserUk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.