On a side note, might I suggest using the CGI module or similar to output HTML, instead of printing it yourself. It will probably make things a lot simpler. Here is an sample of your code rewritten using CGI (plus a few style changes):

use CGI qw(:standard); # use functions instead of OO interface

sub build_select_field_from_db {
    # --------------------------------------------------------
    # Builds a SELECT field from the database.
    my ( $column, $value, $name ) = @_;

    my ( $fieldnum, $found ) = ( 0, 0 );
    for my $i (0 .. $#db_cols) {
        if ($column eq $db_cols[$i]) {
            $fieldnum = $i; $found = 1;
            last;
        }
    }
    if (!$found) {
        return q(error building select field: no fields specified!);
    }
    open my $DB, q(<), $db_file_name or cgierr(qq(unable to open $db_f
+ile_name. Reason: $!));
    my @lines = <$DB>;
    close $DB;
    my @selectfields;
    LINE: foreach my $line (@lines) {
        if ($line =~ /^#/) { next LINE; }       # Skip comment lines.
        if ($line =~ /^\s*$/) { next LINE; }    # Skip Blank Lines.
        chomp $line;

        my @fields = split_decode ($line);
        if(!(List::MoreUtils::any { $_ eq $fields[$fieldnum] } @select
+fields)){
            push @selectfields, $fields[$fieldnum];
        }
    }
    my $output = popup_menu(
        -name    => defined $name ? $name : $column,
        -values  => [ '---', sort @selectfields ],
        -default => $value,
    );
    return $output;
}

[download]

In reply to Re: Help syntax? by kejohm
in thread Help syntax? by randallmarquis

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.