The problem is in line 42 of your code.

(Or phrased differently, if you showed your code, it would be much easier to help you).

Update:

Running your code with

use strict; use warnings; # your code here... print rev_compare('1.3', '*');

Results in an error:

Too many arguments for main::rev_compare at foo.pl line 54, near "'*') +" Execution of foo.pl aborted due to compilation errors.

Removing the () after the sub rev_compare fixes this. Then I get

Argument "" isn't numeric in numeric eq (==) at foo.pl line 39. 0
Line 39 is     if ($section_major_number == $main_minor_number)

Which reveals a problem of your code: you don't have sane handling for when the numbers don't contain a dot. Also you only check the first argument for being an asterisk, not the second.

I'd suggest this code instead:

sub rev_compare { my $section = shift; my $main = shift; return 1 if $section eq '*' or $main eq '*'; my @section = split /\./, $section; my @main = split /\./, $main; return ($section[0] == $main[0]) && (($section[1] eq '*' && $main[1] eq '*') || $section[1] == $main[1]); }

I haven't tested it with all values, but it should handle * as the value of the minor version number just fine

Perl 6 - links to (nearly) everything that is Perl 6.

In reply to Re: Comparing revision numbers by moritz
in thread Comparing revision numbers by zek152

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.