my $confpath;
my $servername;
my $filepath;
my $filemaxage;

$confpath = "/export/mksysb";
$filepath = "/export/mksysb";
$filemaxage = "360";

[download]

The usual practice is to define and initialize variables in the same step: 

my $confpath   = '/export/mksysb';
my $filepath   = '/export/mksysb';
my $filemaxage = 360;

[download]

By the way, $confpath and $filepath have the same value so is there really a need for two variables? 

while(<FILE>){
    chomp($servername = $_);

[download]

That is usually written as: 

while ( my $servername = <FILE> ) {
    chomp $servername;

[download]
        if (-M $_ > "$filemaxage"){

[download]

You are converting $filemaxage to a string and then Perl has to convert it back to a number in order to do a numerical comparison.

What's wrong with always quoting "$vars"? 

        mkdir("$filepath/$servername");

system("nim -o define -t mksysb -a server=master -a mk_image=yes -a lo
+cation=$filepath/$servername/$servername\_`date +%m%d%Y` -a source=$s
+ervername $servername\_`date +%m%d%Y`");

[download]

You should also check for failure with mkdir and system like you already do with open and unlink.

In reply to Re: check my code by jwkrahn
in thread check my code by TechFly

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.