Ah, better. This: 

params {
    my ( $self, $cgi ) = @_;
    my %formdata;
    $cgi = CGI::self_or_default if ( ! defined $cgi or ! ref $cgi ) an
+d $cgi;

    if ( defined $cgi and $cgi ) {

[download]
deserves a bit of "improvement". I'll go through step-wise as I hope that will be more enlightening.

I was not able to understand this:     $cgi = CGI::self_or_default if ( ! defined $cgi or ! ref $cgi ) and $cgi; so I did some "mechanical" translation which made it easy for me to understand (this may have more to do with the strange ways in which my mind works, though):     $cgi = CGI::self_or_default   if  $cgi  and  ! ( defined $cgi and ref $cgi ); So we don't want to override $cgi if it is false and we don't want to override $cgi if it is a good reference. But, my testing shows that ref $cgi doesn't produce a warning even if $cgi is undef so we can shorten this to:     $cgi = CGI::self_or_default   if  $cgi  and  ! ref $cgi;

Similarly, $cgi in a "Boolean context" doesn't elicit a warning in the face of undef so:     if ( defined $cgi and $cgi ) { can become:     if (  $cgi  ) {

This brings us to: 

params {
    my ( $self, $cgi ) = @_;
    my %formdata;
    $cgi = CGI::self_or_default   if  $cgi  and  ! ref $cgi;

    if (  $cgi  ) {

[download]
But I'd factor out the if($cgi): 
    if (  $cgi  ) {
        $cgi = CGI::self_or_default   if   ! ref $cgi;

[download]
Finally you can swap if ! with just unless, but I find that mostly a matter of taste.

Well, anyway, that "works" better for me. (:

        - tye (but my friends call me "Tye")

In reply to (tye)Re: (Ovid - Dang, I love this place -- and one more question :) by tye
in thread Typeglobs and Symbol tables by Ovid

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.