Much nicer. One little issue, though:


# This:

$cgi = CGI::self_or_default if $cgi and ! ref $cgi;

# is not equivalent to this:

$cgi = CGI::self_or_default if ! ref $cgi;

[download]

The reason this is the case is how it's called:

print $foo->list_params( 1 );

[download]

If someone supplies a false value, it should return "0". With the second version of your assignment to $cgi, it will always return the params, regardless of whether or not a false value has been passed. That might seem irrelevant, but this is a reduced test case of the actual code. Here's how this will be used in real life:

$write->table( -params    => 1,
               -condition => "$x % 7 == 3",
               -active    => 1,
               -caller    => 0,
               SomeVar    => $some_var,
               DATA       => \%some_hash );

[download]

Since this is part of a debugging module, the programmer may want to turn off the param display once the params are verified, or turn them back on again if there is a problem. Rather than going through and deleting or re-entering the '-param' key, the programmer can just toggle the value at will. (I know we discussed this with /msgs, but this is for the benefit of those not privy to the conversation).

Cheers,
Ovid

Update: Hmm... I seem to be posting a lot of updates lately :(

Seems I missed a little if which drastically changes the meaning of tye's code:

if (  $cgi  ) {
        $cgi = CGI::self_or_default   if   ! ref $cgi;

[download]

sigh

Join the Perlmonks Setiathome Group or just click on the the link and check out our stats.

In reply to (Ovid) Re: (tye)Re: (Ovid - Dang, I love this place :-) by Ovid
in thread Typeglobs and Symbol tables by Ovid

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.