I would write that as

my @images = ( [], [] );
{
    my( @imgstr ) = split /\|/, $str, 2;
    @{ $images[0] } = $imgstr[0] =~ m/(\w+\.jpg)/gi;
    @{ $images[1] } = $imgstr[1] =~ m/(\w+\.jpg)/gi;
}
[download]

because

• using parens with built-in functions is ugly , extra typing
• split takes regex as 1st argument, and you're only expecting it to return 2 parts at most
• avoid slice syntax when you're not taking a slice ($images[0])
• avoid pretend arrays, use real arrays (@imgstr)
• limit scope of temporary variables

Actually I would write

my @images;
{
    my @imgstr  = split /\|/, $str, 2;
    push @images, [ $_ =~ m/(\w+\.jpg)/gi ] for @imgstr;
}
[download]

or actually

my @images = map { [  $_ =~ m/(\w+\.jpg)/gi ] } split /\|/, $str;
[download]

Yes, the last one is how I would normally write something like that, its funny how digesting someone else s code plays tricks on you :)

---

---

Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!

Titles consisting of a single word are discouraged, and in most cases are disallowed outright.

Read Where should I post X? if you're not absolutely sure you're posting in the right place.

Please read these before you post! —

• How do I compose an effective node title?
• How do I post a question effectively?
• Markup in the Monastery

Posts may use any of the Perl Monks Approved HTML tags:

a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr

You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)

	For:		Use:
	&		&
	<		&lt;
	>		&gt;
	[		&#91;
	]		&#93;

Link using PerlMonks shortcuts! What shortcuts can I use for linking?

See Writeup Formatting Tips and other pages linked from there for more info.