You should not ->finish () select handles that are done reading:

my $sth = $dbh->prepare ("select * from foo");
$sth->execute;
while (my $ref = $sth->fetch) {
    print $ref->[0], "\n";
    }
# No need for $sth->finish;

[download]

The safest way to never worry about this is to make those select loops have the smallest possible context, so the handle gets DESTROY'd on leaving scope:

{   my $sth = $dbh->prepare (...);
    $sth->execute;
    ...
    } # End-of-scope: $sth is destroyed

[download]

It is usually advisable to finish update/insert/delete handles, as they have no obvious "done" state.

{   my $stu = $dbh->prepare ("update foo set blah = ? where c_foo = ?"
+);
    my $sth = $dbh->prepare ("select c_foo, bar from brimble");
    $sth->execute;
    while (my $r = $sth->fetchrow_hashref) {
        $stu->execute ($r->{bar}, $r->{c_foo});
        }
    # no need for $sth->finish
    $stu->finish; # Good practice
    } # End of scope: clean up

[download]

Enjoy, Have FUN! H.Merijn

In reply to Re^5: prepared statement by Tux
in thread prepared statement by saintex

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.