I did not understand what you are trying to do exactly.

Are you trying to kill the process if it's been running for more than 1 hour ? or you are killing the process if it doesn't match a given date/time you saved in a local file?

Does your code actually do the job? The process killing part might kill 1 process only ... is that what you really want? Here's your code which might be matched 1 time only

if ($counter == scalar(@rundates)) { 
            print "$procids[$procloop] is outside expected time range.
+\n" ;
            my $cmd = "ssh $nodenum kill -9 $procids[$procloop]";
            #print is to see if anything is killed, and make sure comm
+and syntax is correct
            print "$cmd\n";
            system ($cmd);
        }

[download]

And you can avoid some of your problems like # if the 'ps' output changes order, than may cancel the wrong process by not running separate ssh commands , but using 1 command and parse the output yourself.

In reply to Re: Killing Processes Code Review by ahmad
in thread Killing Processes Code Review by Anonymous Monk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.