Sorry for not responding until now - should have thought about putting this up on a Friday. But to answer:

Are you trying to kill the process if it's been running for more than 1 hour ? or you are killing the process if it doesn't match a given date/time you saved in a local file?

A little of both. I get times from the first grep command, then compare them to the second and third grep results. If they differ by more than an hour, then it should kill the process. I put the time difference in because the ps command was giving times from the future, so I thought some margin would be good.

Does your code actually do the job? The process killing part might kill 1 process only ... is that what you really want?

I only want it to kill processes outside of the time buffer - so even if doesn't actually kill anything, that's fine. The goal is just to get those accidentally left behind, not the ones actually in use. And it does seem to work, at least based on the tests I could come up with. Not knowing why processes continue makes testing hard.

parse the output yourself

The idea with this is to be automated, and possibly even to run automatically at given points. It's not really that much work to do the whole code's function manually, but it needs to be done regularly.

In reply to Re^2: Killing Processes Code Review by Anonymous Monk
in thread Killing Processes Code Review by Anonymous Monk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.