Hey monks. Ive been getting back on the perl bandwagon after about 2 years. My last (very small) attempts were based solely on editing and modifying someone elses code during uni but this time Ive been working through the Llama book and doing it properly. I want to spend more time doing and less time reading so Ive been getting my family to set me problems to fix as I go along (chapter 4 now!).

Seen as there are no right answers if you guys and gals see any errors in style or superfluous-ness (its a word!) I'd appreciate any feedback.

This was to work out all the factors of a number: 
#!/usr/bin/perl
use warnings;

print "Type number you want factorised: \n";
chomp($no = <STDIN>);
@int = (1..($no/2));
print "The factors of $no are: \n";
foreach $int (@int) {
        $div = $no/$int;
        $remainder = $no % $int;
                if ($remainder == 0){
                print "$div\n";
                }
        }

[download]
Thanks for looking M

In reply to First code - Factors by mabeuf

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.