Using warnings is a good start, but the rest of the strictures mantra is to use strict. Personally I like a little more white space around the place and have tuned Perl::Tidy to do it the way I like it.

You should avoid overloading variable names. You use both $int and @int. In some cases that can lead to very subtle and hard to find bugs. In fact for this code you don't need the array at all, just plonk the range straight into the for loop list.

Making those few adjustments gives:

#!/usr/bin/perl use strict; use warnings; print "Type number you want factorised: \n"; chomp (my $no = <STDIN>); print "The factors of $no are: \n"; foreach my $int (1 .. $no / 2) { my $div = $no / $int; my $remainder = $no % $int; if ($remainder == 0) { print "$div\n"; } }
True laziness is hard work

In reply to Re: First code - Factors by GrandFather
in thread First code - Factors by mabeuf

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.