maebuf:

You've already received some good comments. I'll just make a couple here:

• In your loop, you're doing a divide and a modulus every iteration. You could do the divide only when the modulus leaves no remainder.
• You don't really need to store the result of the modulus in a variable since you're using it only in your if statement. So you could just move the calculation to your if statement.
• Similarly, you're creating an array from a sequence, and then using the sequence only in one place. You could put the sequence in the for loop where you use it.

Putting those together would give you:

foreach $int (1 .. ($no/2)) {
   if ($no%int == 0) {
      $div = $no / $int;
      print "$div\n";
   }
}
[download]

Algorithmically, you're doing quite a few operations that will *never* give you a factor, because your sequence includes even numbers other than two. You could generate a list that includes 2 and all the odd numbers up through half of the input number like this:

foreach $int (2, map {$_*2+1} (1 .. ($no/4)) {
  ....
[download]

I hope you find it helpful.

...roboticus

Update: If you want to crunch the code down, you could even combine most of it to a single statement:

print "$_\n" for grep { 0==$no%$_ } (2, map { 2*$_+1 } 1 .. $no/2);
[download]

Note: Another thing to watch for is that you're not restricting yourself to prime factors. I don't know if it matters to you, though.

---

---

Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!

Titles consisting of a single word are discouraged, and in most cases are disallowed outright.

Read Where should I post X? if you're not absolutely sure you're posting in the right place.

Please read these before you post! —

• How do I compose an effective node title?
• How do I post a question effectively?
• Markup in the Monastery

Posts may use any of the Perl Monks Approved HTML tags:

a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr

You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)

	For:		Use:
	&		&
	<		&lt;
	>		&gt;
	[		&#91;
	]		&#93;

Link using PerlMonks shortcuts! What shortcuts can I use for linking?

See Writeup Formatting Tips and other pages linked from there for more info.