Here's a shorter, data-driven version of your program that produces the same output as yours, and should be more efficient too:
#!/usr/bin/perl -w use strict; use warnings; print "Content-type: text/html\n\n"; my @locations = qw(LA LB LC LD LE); my %loc = ( LA => { NE => 1, E => 1, SE => 1, S => 1, SW => 1 }, LB => { NE => 1, SW => 1, W => 1, NW => 1}, LC => { SE => 1, S => 1, SW => 1}, LD => { SE => 1, S => 1, SW => 1}, ); my %results = ( LA => '1LA= NE|E|SE|S|SW', LB => '2LB= NE|SW|W|NW', LC => '3LC= SE|S|SW', LD => '4LD= SE|S|SW', ); my $c_position = ''; foreach my $location (@locations) { my $test_loc = "Park: SW at 10 position"; #this could be for LA my $locs = substr $test_loc, 6, 2; $locs=~s/\s+//; $c_position .= ' '; if ($loc{$location}{$locs}) { $c_position .= $results{$location}; } else { $c_position .= '5ALL OTHERS HERE.'; } } print "Results= $c_position\n\n";

This is not quite perfect; for example one could unify %results %loc (pretty easy if the order of letters in the values of %results doesn't matter), but it's a start.

It also makes it possible to read the hashes from config files, so that a long list of conditions requires no code change.

Perl 6 - links to (nearly) everything that is Perl 6.

In reply to Re: Code Efficiency and Dynamic Help! by moritz
in thread Code Efficiency and Dynamic Help! by Anonymous Monk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.