Using perlcritic -4 on my code I'm down to messages like: 
Found use of die. Use an exception instead at line 38, column 8.  Exce
+ption objects 
should be used instead of the standard Perl error mechanism.  (Severit
+y: 4)

[download]

The 'offending' code is:

$hECO = retrieve($ECO_path)
    or die "Couldn't open $ECO_path : $!";
$hNIC = retrieve($NIC_path)
    or die "Couldn't open $NIC_path : $!";
$hOpening = retrieve($Opening_path)
    or die "Couldn't open $Opening_path : $!";

[download]

I'm wondering if the following is equivalent?

eval {
    $hECO = retrieve($ECO_path);
    1;
} or do {
    print "Couldn't open $ECO_path : $@";
    exit;
}
eval {
    $hNIC = retrieve($NIC_path);
    1;
} or do {
    print "Couldn't open $NIC_path : $@";
    exit;
}
eval {
    $hOpening = retrieve($Opening_path);
    1;
} or do {
    print "Couldn't open $Opening_path : $@";
    exit;
}

[download]

I'm also wondering if it is safe? What alternatives are there that don't drag in a mountain of dependencies? I've looked at Try::Tiny and TryCatch. Error is pretty much deprecated. If I have to I'll leave the code as is— but as a sort of intellectual challenge, I'd like to see what can be done.

--hsm

"Never try to teach a pig to sing...it wastes your time and it annoys the pig."

In reply to eval to replace die? by hsmyers

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.