Very small critisms that go a long way:
  1. Instead of using $DEBUG as a variable, why not 'declare' it as a constant: 
    use constant DEBUG => 0;

    [download]
  2. Testing if something is equal to "1" is overkill, all you need to know is if the variable is non-zero or not. Both of these are equal in consequence: 
    print gmtime($object) ."\n" if $DEBUG == "1";
print gmtime($object) ."\n" if $DEBUG;

# ahem, but since we'll be using the constant DEBUG
print gmtime($object) ."\n" if DEBUG; # sorry i didn't mention this ea
+rlier

    [download]
  3. last issue, your first for loop: 
    for ( @filename ) {
    my $filename = $_;
    ...
}

    [download]
    can be more consisely written as: 
    for my $filename (@filename) {
    ...
}

    [download]
Other than that, it works, and that's the most important thing, right? :)

Jeff 

R-R-R--R-R-R--R-R-R--R-R-R--R-R-R--
L-L--L-L--L-L--L-L--L-L--L-L--L-L--

In reply to (jeffa) Re: macls.pl by jeffa
in thread macls by snafu

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.