Assuming the first example is the correct one as far as the status value goes, I'd code it this way.

Update:tweaked it a bit. 

sub bar {
    my($self) = @_;
    my $rv = { status => 0, error => undef, external_id => undef };
    
    $rv->{ error } = "Authentication Failed" and return $rv
        unless $self->authenticate_user();
   
    my $profile = $self->get_user_profile();
   
    $rv->{ error } = "User is not active"  and return $rv
        unless $profile->is_active();
        
    $rv->{ external_id } = $self->find_external_id( $profile ) //
        $self->send_profile_to_partner( $profile );
    
    $rv->{ status } = 1;
    return $rv;
}

[download]

In reply to Re: Control Flow - Multiple returns or nested conditionals by BrowserUk
in thread Control Flow - Multiple returns or nested conditionals by JediWizard

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.