My rewrite is pretty similar to DBX's.

The main points:

• always, ALWAYS, use strict and -w,
• you use arrays in a lot of places where you really should be using scalars,
• you don't need a hash (%where if you are only going to ever use it's keys, you can use an array instead,
• you had 2 nested loops, where the second one (the foreach should really be outside. Actually you don't even need that extra loop, you can just do the find if the uid is a user uid,

#!/usr/bin/perl -w
use strict;

# better to have it as a clearly defined parameter
# mine is 500 for example
my  $MIN_USER_UID = 1000;

$|++;

open PASSWD, '/etc/passwd';
my @user;
while (<PASSWD>){
  my @field = split /:/;
  system ("find '/home/u1'  -user $field[0] -print >$field[0]") if($fi
+eld[2] > $MIN_USER_UID);
  }
[download]

---

---

Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!

Titles consisting of a single word are discouraged, and in most cases are disallowed outright.

Read Where should I post X? if you're not absolutely sure you're posting in the right place.

Please read these before you post! —

• How do I compose an effective node title?
• How do I post a question effectively?
• Markup in the Monastery

Posts may use any of the Perl Monks Approved HTML tags:

a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr

You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)

	For:		Use:
	&		&
	<		&lt;
	>		&gt;
	[		&#91;
	]		&#93;

Link using PerlMonks shortcuts! What shortcuts can I use for linking?

See Writeup Formatting Tips and other pages linked from there for more info.