Unfortunately, that version does not work in the case of a non-matching regex, producing an invalid hash with an odd number of elements, because a non-match produces an empty list (not undef). It can be fixed with:

my %inc = map { $_ => ($content =~ /inc_$_=(.*?)\n/)[0] || undef } qw(albums genres artists songs ratings year);
Update: The || above should be // to cater for the edge case of "inc_artists=0". Note that the // "defined or" operator was added to Perl 5.10. Note further that the low precedence version of this operator has morphed from err to dor to orelse; orelse is in Perl 6 as a similar but not identical low precedence version of //, but not in Perl 5 AFAICT.

Test program to demonstrate follows. Running:

use strict; use warnings; use Data::Dumper; my $content = <<'GROK'; inc_albums=albumvalue inc_genres=genrevalue inc_artists =artistvalue inc_songs=songsvalue inc_ratings=ratingsvalue inc_year=yearvalue GROK { my %inc = map { my ($v) = $content =~ /inc_$_=(.*?)\n/; $_ => $v } qw(albums genres artists songs ratings year); print Dumper(\%inc); } { my %inc = map { $_ => ($content =~ /inc_$_=(.*?)\n/)[0]; } qw(albums genres artists songs ratings year); print Dumper(\%inc); } { my %inc = map { $_ => ($content =~ /inc_$_=(.*?)\n/)[0] || undef } qw(albums genres artists songs ratings year); print Dumper(\%inc); }
produces:
$VAR1 = { 'artists' => undef, 'ratings' => 'ratingsvalue', 'songs' => 'songsvalue', 'genres' => 'genrevalue', 'albums' => 'albumvalue', 'year' => 'yearvalue' }; Odd number of elements in hash assignment at ff2.pl line 21. $VAR1 = { 'ratingsvalue' => 'year', 'songsvalue' => 'ratings', 'artists' => 'songs', 'genres' => 'genrevalue', 'yearvalue' => undef, 'albums' => 'albumvalue' }; $VAR1 = { 'artists' => undef, 'ratings' => 'ratingsvalue', 'songs' => 'songsvalue', 'genres' => 'genrevalue', 'albums' => 'albumvalue', 'year' => 'yearvalue' };


In reply to Re^4: Changing variable names in a loop by eyepopslikeamosquito
in thread Changing variable names in a loop by Mad_Mac

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.