Hi all

I have a class that can create an object using data coming from different sources / formats. Like: 

package My

sub new {
   my ($class,%args) = @_;
   my $self = bless {}, $class;

   if ($args{source} eq 'xml') {
      require My::XML;
      @ISA = qw/My::XML/;
   } elsif ($args{source} eq 'json') {
      require My::JSON;
      @ISA = qw/My::JSON/;
   }
   $self->_init(); # Versions in both My::XML and My::JSON

   return ($self);
}
# rest of methods
sub method1 { ... }
sub method2 { ... }

[download]

The packages My::XML and My::JSON: 

package My::XML;

sub _init { ... }
1;

package My::JSON;

sub _init { ... }
1;

[download]

The calling code would be:

use My;

my $obj = My->new(source=>"xml");
# Do whatever with $obj

[download]

Is this a correct design to face this? Any caveat you may anticipate? Are there better alternatives?

Thank you very much in advance for your help

citromatik

In reply to Conditional inheritance strategy by citromatik

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.