You have a logic problem and a design problem.

Logic problem: read 1st line of update file; read first to last lines of master file; read 2nd line of update file; oops - nothing left to read from master file.

Design problem: processing the entire master file for every line of the input file - MishaMoose alluded to this (above).

Try creating a hash (say %index) then read through the update file only and for each line store the data in the hash ($index{$key} = $line;). Next, read through the master file and for each line process its key against $index{$key}. That way you only read the files once.

Be aware, this assumes that the keys are unique!

-- Ken

In reply to Re: compare two files and update by kcott
in thread compare two files and update by mmittiga17

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.