Your pseudocode above suffers from a problem: in creating your database handle, you set RaiseError to true. This means that your script will die on any database error, which is exactly what you don't want. At a bare minimum, you would likely want something closer to: 

my $dbh = DBI->connect("DBI:mysql:database=$sql_database;host=$sql_hos
+t;port=$sql_port",
                       $username,
                       $password,
                       {
                            RaiseError => 0,
                        }
                       )
    or die "DB connect failed: $DBI::errstr";
    
for my $record (@records) {
    unless ($dbh->do($insertstr,
                     undef,
                     $slice->seq_region_name(),
                     $vf->start $vf->variation_name(),
                     $vf->allele_string()
            )) {
        print INSERTLOG "failed to insert", , "\n";

    } #end unless
}#end loop

[download]

However, if you are doing multiple inserts, I would suggest preparing a single statement outside the loop and then binding parameters and executing inside the loop. You'll also likely want to use $DBI::errstr to output more useful diagnostics. This is all discussed in DBI. See RaiseError, Placeholders_and_Bind_Values, $DBI::errstr, and PrintError.

In reply to Re: beginner - looping to insert a set of database records by kennethk
in thread beginner - looping to insert a set of database records by Anonymous Monk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.