Hi Monks!
I would like an opinion if adding "NEXT" at the end of the "IFs" will improve the process on this particular block of code. Or not.
Thanks!
Here is the block of code in spec.
...

  for (my $i = 0; $i < @{$mydata}; $i++) {

    $account_number     = $mydata->[$i]{'account_number'} || '';
    $name   = $mydata->[$i]{'name'} || '';
    $email  = $mydata->[$i]{'email'} || '';

    if($email eq '') {    
      bad_email("No email address found '$account_number'."); 
      next; # <------ here
     }
    elsif ($email !~ /^[A-Z0-9._%+-]+@[A-Z0-9.-]+\.[A-Z]{2,4}$/i ) {
      $msg = "Invalid email address - '$email' on account '$account_nu
+mber'.";
      bad_email($msg); 
      next; # <------ here
    }
    elsif (($name eq '') || ($account_number eq '')) {
      $msg = "Missing information: Number = '$account_number', Name = 
+'$name'.";
      next; # <------ here
    }
    else {
      # Send  emails
      send_email( send my stuff here);
      my $data = "<tr><td align=\"left\">".$account_number."</td><td>"
+.$email."</td></tr>";
      push @all_data, $data;

    }
  
    $sql = "update table set date = '$datetime' where number = '$accou
+nt_number' and date = '$mydata->[$i]{'date'}'";
    exec_single_sql($sql, $db) || die "Unable to update table";
  }
  
...

[download]

In reply to Next in IF statement question! by Anonymous Monk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.