Before building the email message, check all variables and perform appropriate actions if they aren't set or don't have suitable values. Those actions might be to call an error handling routine, output a warning message, supply a default value and so on.

You might also consider building the components of the message separately. For instance:

if ($email_400) {
    my $problem_description = $ENV{REDIRECT_URL}
        ? "A request was received for the file $ENV{REDIRECT_URL}, whi
+ch does not exist."
        : "A file request was received but no filename was supplied.";
    send_mail(...
    ...
    $problem_description
    ...
EOF

[download]

-- Ken

In reply to Re: uninitialized value in concatenation by kcott
in thread uninitialized value in concatenation by Galceran

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.