Write Perl not C (see the for loop below). Use strictures and lexical variables. Use early exits (that's yes use next to your question btw). Oh, and use place holders in your SQL:

for my $datum (@{$mydata}) {
    my $account_number = $datum->{'account_number'} || '';
    my $name           = $datum->{'name'}           || '';
    my $email = $datum->{'email'};

    if (! $email) {
        bad_email("No email address found '$account_number'.");
        next;
    }

    if ($email !~ /^[A-Z0-9._%+-]+@[A-Z0-9.-]+\.[A-Z]{2,4}$/i) {
        bad_email(
            "Invalid email address - '$email' on account '$account_num
+ber'.");
        next;
    }

    next if ($name eq '') || ($account_number eq '');

    # Send  emails
    send_email("send my stuff here");
    my $data = qq(<tr><td align="left">$account_number</td><td>$email<
+/td></tr>);

    push @all_data, $data;

    my $sql = "update table set date = ? where number = ? and date = ?
+";
    exec_single_sql($sql, $db, $datetime, $account_number, $datum->{da
+te}) 
        or die "Unable to update table";
}

[download]
True laziness is hard work

In reply to Re: Next in IF statement question! by GrandFather
in thread Next in IF statement question! by Anonymous Monk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.