I am a new person at my job, and I started going through a lot of the Perl scripts. The previous employee is doing a lot of this:
$hotfix=join "", "$app", "_", "$mod", "_", "$bld", "_", "$hf", ".zip";
$fullpath=join "", "$Upload_Loc", "/", "$filename";
While I would probably do something like this
$hotfix = "${app}_${mod}_${bld}_${hf}.zip";
$fullpath = "$Upload_Loc/$filename";
Or maybe
$hotfix = join("_", $app, $mod, $bld, $hf) . ".zip";
$fullpath = $Upload_Loc . "/" . $filename;
Is there a reason why his way may be better than my way?
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.