As the perpetrator of that node, you could make the code shorter:
my $Hack = 'sub {' . $Subroutine->[2] . '}'; my $sub = eval "$Hack"; undef &{ *VWP_GenQueryHTML{CODE} }; *VWP_GenQueryHTML = $SubRef;
We've used a similar technique in Everything to speed up common page components, and haven't run into any trouble with eval "filling up". There are reports that certain versions of Perl have a leak in eval-string constructs, but it's more likely you'll run out of memory first.

There's no error checking to see if the compilation fails, and, if you're not extremely careful on the code from the database, it's easy to create some code that'll fail right off the bat

For example, if you have a comment as the last line of the code in the database, the interpreter won't see the closing brace of the subroutine declaration.

I'd definitely check $@ to see if the eval failed and I'd make sure $sub and &$sub are both defined before assigning to the glob.


In reply to Re: Odd eval Problem by chromatic
in thread Odd eval Problem by nontrivial

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.