SvLEN( c ) = 2;

should be

SvLEN( c ) = 0;

since Perl isn't free to free the buffer. Furthermore, you replace the buffer you created with newSV without ever deallocating it, so you are leaking.

Solution 1:

void strIter(SV* code, SV* string) { dSP; STRLEN i; char* src = SvPV(string, i); SV* c; c = newSV_type(SVt_PV); SvCUR(c) = 1; SvLEN(c) = 0; SvPOK_only(c); SAVE_DEFSV; DEFSV_set(c); while (i--) { SvPVX(c) = src++; PUSHMARK(SP); call_sv(code, G_NOARGS | G_VOID | G_DISCARD); } }

Solution 2:

void strIter(SV* code, SV* string) { dSP; STRLEN i; char* src = SvPV(string, i); char* dst; SV* c; c = newSVpvn(" ", 1); dst = SvPVX(c); SAVE_DEFSV; DEFSV_set(c); while (i--) { *dst = *(src++); PUSHMARK(SP); call_sv(code, G_NOARGS | G_VOID | G_DISCARD); } }

In reply to Re: Help me improve my XS. by ikegami
in thread Help me improve my XS. by BrowserUk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.