i was wondering if i could make the statement shorter

I presume you mean the code snippet rather than some specific but unspecified statement. If so, you already did. ->execute($val1, $val2) became ->execute().

What else do you want? You obviously can't skip preparing and executing the statement, and you can't skip fetching the result. That really doesn't leave anything to remove. You could combine prepare and execute, though. 

my $sth = prepare_and execute($dbh, "
   SELECT cols
     FROM ".$dbh->quote_identifier($tableName)."
    WHERE col=constant
      AND col2=constant
");

while (my $row = $sth->fetchrow_hashref) {
   ...
}

[download]

Up to you to write prepare_and execute, but it's trivial.

DBI has shortcuts for collecting your data, but you didn't show how you use the data you fetch.

In reply to Re^3: basic dbi question by ikegami
in thread basic dbi question by Anonymous Monk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.