I'm trying to remove a file from one zip file and add it to another using Archive::Zip. I keep getting incorrect crc on the file that was removed / added. The rest of the files in the archive are readable, not this one.

Update: I split the code that creates the zip files into another script to simplify for debugging and so I could verify neither is corrupt before running the remove/addMember code. Both the source zip files are created with Archive::Zip using addFile and they have no problems. I changed the code below to write to a new zip file to rule out the overwrite() function but still have the problem.

#!/usr/bin/perl
use warnings;
use strict;
use Archive::Zip qw(:ERROR_CODES :CONSTANTS);

my $zip1Name = '.\\tmp\\test1.zip';
my $zip2Name = '.\\tmp\\test2.zip';

my $zip1 = Archive::Zip->new();
my $zip2 = Archive::Zip->new();

if (!-e $zip2Name || !-e $zip1Name) {
      die "run test_arc.pl to create zip files for this.";
} 

unless ( $zip1->read( $zip1Name ) == AZ_OK ) {die 'zip1 read error';}
unless ( $zip2->read( $zip2Name ) == AZ_OK ) {die 'zip2 read error';}
    
my $rm_return = $zip1->removeMember('rr.log');

if ($rm_return) {
     print "removeMember : ", $rm_return->fileName() ,"\n";
     $zip2->addMember($rm_return) or 
          die "Can't add ", $rm_return->fileName() ," to zip!";

} else {print "\$rm_return is undef\n";}

unless ( $zip1->overwrite() == AZ_OK ) { 
         die 'zip1 overwrite() error'; }

#   unless ( $zip2->overwrite() == AZ_OK){die 'zip2 overwrite() error'
+;}
   unless ( $zip2->writeToFileNamed('.\\tmp\\newtest2.zip') == AZ_OK )
+ {
         die 'zip2 write() error'; }
[download]

I ran the checkzip.pl script that came in the examples for Archive::Zip and get this:

Member rr.log CRC error: file says ff147173 computed: 354acf95
CRC errors found.
[download]

I'm using Strawberry Perl 5.12.0 on XP

Update: I found a workaround

Archive::Zip object method addMember() will corrupt the file it if you pass it a member obtained from removeMember( 'filename' ). I found I could use

 $zip->memberNamed( 'filename')

to get a member, then add that without it being corrupted. Then I have to go back and remove it from the first archive.

However, I found that

my $removed_member = $zip1->removeMember( 'foo' ); 
$removed_member->extractToFileNamed('foo');
[download]

worked fine.

---

---

Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!

Titles consisting of a single word are discouraged, and in most cases are disallowed outright.

Read Where should I post X? if you're not absolutely sure you're posting in the right place.

Please read these before you post! —

• How do I compose an effective node title?
• How do I post a question effectively?
• Markup in the Monastery

Posts may use any of the Perl Monks Approved HTML tags:

a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr

You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)

	For:		Use:
	&		&
	<		&lt;
	>		&gt;
	[		&#91;
	]		&#93;

Link using PerlMonks shortcuts! What shortcuts can I use for linking?

See Writeup Formatting Tips and other pages linked from there for more info.