You probably don't want a character class [#\d+,], but rather a (non-capturing) group: (?:#\d+,). But the real problem you're having is that the preceding .* is gobbling up the optional part. So, make it non-greedy, i.e. .*?

for my $update_p4filelog ( "...xyz branch from //source/qcom/qct/multimedia/qtv/player/audiop +layer/rel/1.1/src/file.cpp#1,#8", "...xyz branch from //source/qcom/qct/multimedia/qtv/player/audiop +layer/rel/1.1/src/file.cpp#8", ) { my ($path, $ver) = $update_p4filelog =~ /branch from (.*\/.*?)(?:# +\d+,)?(#\d+)$/; my $update_base_branched_p4path = "$path$ver"; print "$update_base_branched_p4path\n"; } __END__ //source/qcom/qct/multimedia/qtv/player/audioplayer/rel/1.1/src/file.c +pp#8 //source/qcom/qct/multimedia/qtv/player/audioplayer/rel/1.1/src/file.c +pp#8

In reply to Re^9: Regex to grab data after the work "branch from" by Anonyrnous Monk
in thread Regex to grab data after the work "branch from" by perl_mystery

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.