If you are interested in how good your code "looks", install Perl::Critic and run the perlcritic utility. Note that perlcritic knows many rules, and there are several rules that can be ignored or broken. After all, it is a tool to compare perl source with the recommendations in PBP. Perl itself doesn't really care how your code "looks", but your future self perhaps will, because he has to maintain what you write now.

In default mode, perlcritic finds only one thing:

# perlcritic .
./877252.pl source OK
./sam.pm source OK
./status.pm: "return" statement with explicit "undef" at line 45, colu
+mn 3.  See page 199 of PBP.  (Severity: 5)
./tes.pm source OK

[download]

In "brutal" mode (perlcritic --brutal .), perlcritic spits out 96 lines, each with a major or minor problem. Missing version control system markers, indirect object syntax, useless interpolation, whitespace at end of line, and of course the all-lowercase module names, to name some.

All-lowercase module names are reserved for pragmatic modules, you should perhaps change your module names to start with an uppercase letter. Also, when your project grows, better have a separate "namespace" for it. If you have no better idea, start with your name or your company's name, followed by the project name. E.g. BigCorp::Frobnicator::Parser, BigCorp::Frobnicator::Generator, BigCorp::Frobnicator::Logger.

Alexander

--
Today I will gladly share my knowledge and experience, for there are no sweeter words than "I told you so". ;-)

In reply to Re^3: Is there a better way to do this? by afoken
in thread Is there a better way to do this? by markdibley

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.