looks like I will be using perlcritic a lot from now on.

Take it serious, but not too serios. PBP is just that. Best practices, not religion. You will probably not burn in hell if you ignore it. But the one that has to take over your code may wish so. ;-)

In fact, not all "best practices" in PBP are considered "best" among the perlmonks. For that reason, you can configure perlcritic to ignore some rules, or to rate them higher or lower than default.

I'm surprised it doesn't complain about the lack of commenting too.

Comments != documentation. See Pod::Coverage and Test::Pod::Coverage.

I prefer having only few comments in my code, mostly only in places where I fear that my future self may come back and hurt me, i.e. whenever I choose to write cryptic code, use side-effects, or assume special conditions.

Documentation is a completely different thing. At least the API should be clearly documented, often also the algorithms used.

Alexander

--
Today I will gladly share my knowledge and experience, for there are no sweeter words than "I told you so". ;-)

In reply to Re^5: Is there a better way to do this? by afoken
in thread Is there a better way to do this? by markdibley

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.