I'm in the process of building an object, which as one of it's accessors contains a list of other objects.

These other objects are only id/name pairs at the minute but may well grow, so I'm modelling them as proper objects from the start.

What are peoples thoughts on this as a design...

has _industries  => ( is         => 'rw',
                      isa        => 'HashRef[Foo::Industry]',
                      auto_deref => 1,
                      default    => sub { {} },
                      clearer    => 'clear_industries',
                      traits     => ['Hash'],
                      handles    => { has_industry_id     => 'exists',
                                      add_industry        => 'set',
                                      get_industry_for_id => 'get',
                                      industry_ids        => 'keys',
                                      industries          => 'values',
                                      num_industries      => 'count',
                                    },
                    );

[download]

Clearly all the specified handles are how you'd interact with the list/hash.

I don't wanna get 3 months into using this code in various places only to realise a flaw in the design.

Any thoughts, comments, suggestions, issues?

Thanks
Cagao

In reply to Moose Design Thoughts (Traits) by Cagao

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.