I wouldn't bother with -e and -f, I'd go straight to -f. Also, if you're going to delete the original, then why copy it to the new location? Why not just rename the file into the new location and do it all at once? Finally, rather than jumping through hoops with map to get the values from the hash, I'd just get them directly. With those changes, it comes out to something like this:

...
my $dir_to_open = "../../pics";
my $dir_to = "../../back";
while (my $row = $sth->fetchrow_hashref()) {
    for my $imgfile (values %$row) {
        if (-f "$dir_to_open/$imgfile") {
            rename "$dir_to_open/$imgfile", "$dir_to/$imgfile";
        }
    }
}

[download]

...roboticus

When your only tool is a hammer, all problems look like your thumb.

In reply to Re^5: Delete files if they match help! by roboticus
in thread Delete files if they match help! by Anonymous Monk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.