Rather than speculate on efficiency you can always use benchmark. One small point though - whenever you interpolate a string into a m// regex or the first half of a s/// regex you need to backslash your special regex metacharacters $^*()+{[\|.?

The easiest way is to use quotemeta. 

foreach $key (keys %hash) {
    $key = quotemeta $key;
    $text =~ s/$key/$hash{$key}/eg;
}

[download]

This is *vital* for reliability. Otherwise you will get unexpected runtime failures when your data eventually contains metachars (typos, deliberate, malicious...) 

use Benchmark;

timethese(10000, {

    'Simple loop' => '

    $text = "This is my test string";
    %hash = qw(test text foo bar use loop the end);
    foreach $key (keys %hash) {
        $key = quotemeta $key;
        $text =~ s/$key/$hash{$key}/eg;
    }

                     ',

    'Alternation' => '

    $text = "This is my test string";
    %hash = qw(test text foo bar use loop the end);
    $regex = join("|", map(quotemeta, keys %hash));
    $text =~ s/\b($regex)\b/$hash{$1}/eg;

                     ',
    }
);

Output:

Benchmark: timing 100000 iterations of Alternation, Simple loop...
Alternation:  5 wallclock secs ( 4.12 usr +  0.00 sys =  4.12 CPU) @ 2
+4271.84/s (n=100000)
Simple loop: 10 wallclock secs ( 9.72 usr +  0.00 sys =  9.72 CPU) @ 1
+0288.07/s (n=100000)

[download]

So as it happens alternation is twice as fast. I thought your solution would be faster but there you go!

If in doubt - use Benchmark

Cheers

tachyon

In reply to Re: Re: Re: using a hash to do substitution? by tachyon
in thread using a hash to do substitution? by mr.dunstan

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.