hakkum:

Just a few minor notes:

• You're processing a command-line argument inside of random_password. That gives you a hidden data path that can be difficult to work with in a larger program.
• Comments like # define variables are useless, as it's quite obvious that you're doing just that. If the code is obvious, you don't need the comment. If the code isn't obvious, then usually it's better to make it obvious rather than comment it. For example:
  

  # default password length
  $pass_len = 14;
  [download]

  Would be better as:
  

  $dflt_pass_len = 14;
  [download]

• Declaring your variables at the point of use is better practice.
• I prefer using return expression rather than expression to return a value to the caller.

Here's a slight update of the random_password subroutine for demonstration:

sub random_password {
    my ($pass_len) = @_;

    my @chars_in_pass = character_pool();

    my $password='';
    for (1..$pass_len) {
        my $random_number = int rand @chars_in_pass;
        $password     .= $chars_pool[$random_number];
    }

    return $password;
}
[download]

I don't mean to indicate that your program is bad in any way. Overall, it's an impressive first program.

...roboticus

When your only tool is a hammer, all problems look like your thumb.

---

---

Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!

Titles consisting of a single word are discouraged, and in most cases are disallowed outright.

Read Where should I post X? if you're not absolutely sure you're posting in the right place.

Please read these before you post! —

• How do I compose an effective node title?
• How do I post a question effectively?
• Markup in the Monastery

Posts may use any of the Perl Monks Approved HTML tags:

a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr

You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)

	For:		Use:
	&		&
	<		&lt;
	>		&gt;
	[		&#91;
	]		&#93;

Link using PerlMonks shortcuts! What shortcuts can I use for linking?

See Writeup Formatting Tips and other pages linked from there for more info.