You also have another major problem in your script with this line:

    $dbh->do(qq/insert into "$DBTABLE" (Artist, Title, Album) values ($artist, $title, $album/) or warn "failed to insert $artist, $title, $album into table - $dbh->errstr" if ($@);

Basically, your insert statement will never run because it will only run if there is an eval error, $@. I would advise you to change your script in the following ways by doing better error checking and using placeholders in your insert statement:

#!/usr/bin/perl use DBI; use strict; use warnings; # Declare varaibles my $DBNAME = "Test"; my $DBTABLE = "Pandora"; my $DBUSER = "slacker"; my $DBPASS = "password"; my $DBHOST = "localhost"; my $csvfile = "/tmp/nowplayingtest.csv"; # Connect to database at hand, or die my $dbh = DBI->connect("DBI:mysql:$DBNAME:$DBHOST", $DBUSER, $DBPASS) or die "DB connect failed: $DBI::errstr"; my $update_h = $dbh->prepare(qq{INSERT INTO $DBTABLE (Artist, Title, A +lbum) VALUES (?, ?, ?)}); open my $ih, $csvfile or die "Can't open file, $csvfile: $!"; while (<$ih>) { chomp; my @rows = split ';'; # Is a semicolon your delimiter, or is it a +comma? my $artist = $rows[0]; my $title = $rows[1]; my $album = $rows[2]; $update_h->execute($artist, $title, $album) or die $dbh->errstr; } my $res = $dbh->selectall_arrayref( q( SELECT Artist, Title, Album FRO +M Pandora)); foreach( @$res ) { print "\n$_->[0], $_->[1] $_->[2]\n\n"; }

- Miller


In reply to Re: Use of uninitialized value... by wind
in thread Use of uninitialized value... by cmd.line.geek

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.