You seem to abuse PuTTY as a way to automatically send commands via SSH to a remote host. Why don't you use one of the SSH libraries available at CPAN? If you can't use them, why don't you use plink.exe?

Funny that you still assume that one will need to enter a password to log in to a remote system. I prefer using public key systems, no need to enter a password all the times.

sudo su - $userid looks old. sudo should know the -i parameter, giving you a login session without the extra work of invoking su. It should also know the -u parameter to select a user different from root, by name or by UID.

Depending on how sudo was configured, it will not always ask for a password, but your StartPutty function does not check for that condition. Instead, it blindly enters the password, already having root permissions. Let's hope no user has "rm -rf /" as password.

The code around sudo has two "long" sleeps, during that time, some nasty popup could steal the focus. That would completely break your code, because the keys you send never arrive at the server. It will still sit there waiting for a user command or a password when you try to feed it root commands. You should at least check for prompts. Better, get rid of those remote-controlling attempts. It can't work reliable. Create an SSH connection from within perl or use the plink.exe helper when you can't use an SSH library.

Alexander

--
Today I will gladly share my knowledge and experience, for there are no sweeter words than "I told you so". ;-)

In reply to Re: How to Resize a Window in M$ Windows? by afoken
in thread How to Resize a Window in M$ Windows? by NateTut

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.