Assuming you don't want to implement a regular expression interpreter, then I'd bet your code is fairly close to optimal. You could simplify your test to
use strict; use warnings; for ('a*', '*') { print validate($_) ? "Pass: '$_'\n" : "Fail: '$_'\n"; } sub validate{ my $pat = shift; return eval{qr/$pat/}; }
where it returns the compiled regular expression if it succeeds (TRUE) or undef if it fails (FALSE). (In general IMHO, it's a good idea to just return; on failure, since return 0; will evaluate to TRUE in list context. will return a non-empty list if the sub is evaluated in list context)

Blah blah, security, blah blah, trusted source, blah blah, injection attack, blah blah, perlsec.

Update: In deference to ikegami's comment, I have revised the above; however I would point out that Perl Best Practices agrees with me (point 124 - Use a bare return to return failure). I think we can both agree that the interface you specify should depend on how you are going to use it.


In reply to Re: Validating Regular Expression by kennethk
in thread Validating Regular Expression by Anonymous Monk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.