seblec:

To be honest, I would normally do it in the SQL, letting it do the grunt work of grouping the data, finding the max and sum:

select category||type as grp, max(category) as cat, max(type) as typ,
       sum(quantity) as qty
from table
group by category || type

[download]

On the perl side, I think you're trying to make rowsGroupBy too "smart". Rather than doing one task well, you're trying to make it a jack-of-all trades. I would think that a simple function that would return a list of records with the group-by keys would be a single function I'd use, something like:

sub group_by {
    my ($rows, $group_keys) = @_;
    my @recs=();
    for my $row (@$rows) {
        push @recs, {
            GRP=>join(chr(28),@{$row}{@$group_keys}),
            %$row 
        };
    }
    return @recs;
}

[download]

Similarly, you could write other single-purpose functions to handle MAX and SUM, or use functions from List::Util and List::MoreUtils to do the other jobs.

...roboticus

When your only tool is a hammer, all problems look like your thumb.

In reply to Re: Improve this "group by" perl sub by roboticus
in thread Improve this "group by" perl sub by seblec

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.