Didn't see any warning, but the code quickly evolved to this:
my $hr = $tvdb->getSeriesBanners($title, 'season', 'seasonwide');
my $rating = 0;
my $bwurl;
my @keys = keys %$hr;
foreach my $id (@keys) {
my $hr2 = $hr->{$id};
if (($hr2->{Season} == $seasonnum) && ($hr2->{Rating} > $rating))
+{
$rating = $hr2->{Rating};
$bwurl = $hr2->{BannerPath};
}
}
if ($bwurl) {
debug(1, "Using highest rated Series Banner\n");
return "http://thetvdb.com/banners/_cache/$bwurl";
}
In which I now see a bug: If the only banner(s) available have a zero Rating, I end up with nothing. I'll change it to -1.
The Rating is a 0..10 scale AFAIK (Thetvdb.com via TVDB::API), and I always use strict; use warnings;
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.