Yes, there are a few problems with that code:

• 1) Your subroutine relies on the global variable $SQL, instead of a passed parameter.
• 2) Your $SQL statements are vulnerable to injection attacks since they aren't escaped and/or you're not using placeholders.
• 3) You rolling your own to browser error reporting, instead of letting CGI::Carp do the work for you.

#!/usr/bin/perl -wT

use CGI;
use CGI::Carp qw(fatalsToBrowser);
use DBI;

use strict;
use warnings;

...

    my $sth = $dbh->prepare(qq{UPDATE $regtable SET favorites=? WHERE 
+ID=?});
    $sth->execute($favorites, $ID) or die $dbh->errstr;

...
[download]

The above is all you need to accomplish the same thing. If there is an error with your statement, then CGI::Carp will trap it and display it in the browser and also the error log.

---

---

Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!

Titles consisting of a single word are discouraged, and in most cases are disallowed outright.

Read Where should I post X? if you're not absolutely sure you're posting in the right place.

Please read these before you post! —

• How do I compose an effective node title?
• How do I post a question effectively?
• Markup in the Monastery

Posts may use any of the Perl Monks Approved HTML tags:

a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr

You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)

	For:		Use:
	&		&
	<		&lt;
	>		&gt;
	[		&#91;
	]		&#93;

Link using PerlMonks shortcuts! What shortcuts can I use for linking?

See Writeup Formatting Tips and other pages linked from there for more info.